Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SIGTERM in build command #5813

Merged
merged 1 commit into from Oct 28, 2021
Merged

fix: handle SIGTERM in build command #5813

merged 1 commit into from Oct 28, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 28, 2021

Motivation

Sometimes trying to kill a build process does not work (hard to test).

This is a little attempt to see if it improves things.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local usage over time and see if issues happen again

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 28, 2021
@slorber slorber requested a review from lex111 as a code owner October 28, 2021 16:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ [V2]

🔨 Explore the source changes: 84e2272

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617acf910c3234000886eb3a

😎 Browse the preview: https://deploy-preview-5813--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5813--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 38 kB
website/build/assets/css/styles.********.css 94 kB
website/build/assets/js/main.********.js 425 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB
website/build/blog/index.html 39 kB
website/build/docs/index.html 46.1 kB
website/build/docs/installation/index.html 53.6 kB
website/build/index.html 31.6 kB
website/build/tests/docs/index.html 27.3 kB
website/build/tests/docs/standalone/index.html 23.8 kB

compressed-size-action

@slorber slorber merged commit 768600e into main Oct 28, 2021
@slorber slorber deleted the slorber/build-sigterm branch October 28, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants