Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require Node 14 #5812

Merged
merged 2 commits into from Oct 28, 2021
Merged

chore: require Node 14 #5812

merged 2 commits into from Oct 28, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 28, 2021

Motivation

Require Node.js >= 14

We want to upgrade react-dev-server and react-dev-utils in #5420, but CRA/react-dev-utils will require Node.js 14 too on the upcoming Webpack 5 release.

About the Node upgrade strategy:

  • Node 12 is still in Maintenance LTS (security fixes are backported)
  • We should probably not wait for the end of maintenance period to do the upgrade, but plan ahead: in the future, I think we should start thinking about the upgrade every time a Node version goes from active to maintenance

image

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

CI

@slorber slorber added pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Oct 28, 2021
@slorber slorber requested a review from lex111 as a code owner October 28, 2021 14:58
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ [V2]

🔨 Explore the source changes: abffab6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617abaa5b306300007c47949

😎 Browse the preview: https://deploy-preview-5812--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5812--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 38 kB
website/build/assets/css/styles.********.css 93.8 kB
website/build/assets/js/main.********.js 425 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB
website/build/blog/index.html 39 kB
website/build/docs/index.html 46.1 kB
website/build/docs/installation/index.html 53.6 kB
website/build/index.html 31.6 kB
website/build/tests/docs/index.html 27.3 kB
website/build/tests/docs/standalone/index.html 23.8 kB

compressed-size-action

@slorber slorber merged commit 1ce6253 into main Oct 28, 2021
@slorber slorber deleted the slorber/require-node14 branch October 28, 2021 15:11
@Josh-Cena
Copy link
Collaborator

This means:

Full ESM support!

tnir added a commit to tnir/forem-docs that referenced this pull request Apr 12, 2022
Netlify uses Node.js 12 as default, but Docusaurus droped Node.js 12
support at v2.0.0-beta.9:

facebook/docusaurus#5812

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir added a commit to tnir/forem-docs that referenced this pull request Apr 12, 2022
Netlify uses Node.js 12 as default, but Docusaurus dropped Node.js 12
support at v2.0.0-beta.9:

facebook/docusaurus#5812

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants