Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Sidebar is covering NavBar Buttons #4826

Closed
fabrusso opened this issue May 21, 2021 · 7 comments 路 Fixed by #4833
Closed

Doc Sidebar is covering NavBar Buttons #4826

fabrusso opened this issue May 21, 2021 · 7 comments 路 Fixed by #4833
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.

Comments

@fabrusso
Copy link

fabrusso commented May 21, 2021

馃悰 Bug Report

The navbar in the documentation page is not working.
Is correctly working in the Home page.

I checked the the HTML and It seems that the sidebar containing Doc link has a margin-top that is covering the buttons area.

Have you read the Contributing Guidelines on issues?

yes

To Reproduce

If possible, use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.

(Write your steps here:)

  1. Go to documentation
  2. Try click on navbar "left positioned" button near the logo

Expected behavior

I expect the buttons to redirect me to the url\src

Actual Behavior

Buttons are not clickable

Your Environment

  • Docusaurus version used: @docusaurus/core": "^2.0.0-beta.0
  • Environment name and version: Mozilla for Developers
  • Operating system and version (desktop or mobile): MacOS BigSur

Reproducible Demo

Doc to check:
https://crono.matchplat.io/docs/installation/installation

Current margin of the child DIV:
Schermata 2021-05-21 alle 12 18 34

Parent DIV covering:
Schermata 2021-05-21 alle 12 21 41

Disabling that margin-top:
Schermata 2021-05-21 alle 12 21 47

The Sidebar with no Margin Top and clickable buttons:
Schermata 2021-05-21 alle 12 21 59

@fabrusso fabrusso added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels May 21, 2021
@fabrusso fabrusso changed the title NavBar button are not clickable Doc Sidebar is covering NavBar Buttons May 21, 2021
@lex111
Copy link
Contributor

lex111 commented May 21, 2021

@fabrusso hi, could you please provide a reproducible repo or website link?

@fabrusso
Copy link
Author

@fabrusso hi, could you please provide a reproducible repo or website link?

https://crono.matchplat.io/docs/installation/installation

Thanks.

@mhwinkler
Copy link

I'm also experiencing this issue, it may be related to CSS minification.

When using the local server, my /styles.css contains:

--ifm-z-index-dropdown: 100;
--ifm-z-index-fixed: 200;
--ifm-z-index-overlay: 400;

After a production build, the same lines read:

--ifm-z-index-dropdown: #100;
--ifm-z-index-fixed: #200;
--ifm-z-index-overlay: #400;

@lex111
Copy link
Contributor

lex111 commented May 21, 2021

This was fixed in PR cssnano/cssnano#1122 @omgovich thanks for that!

@fabrusso @mhwinkler we have explicitly bumped the appropriate versions of CSS minification packages, but since we use caret ranges, you can simply reinstall dependencies of your site and remove previous build artifacts by running yarn clear command, after that the issue will be fixed.

@ishan-grubtech
Copy link

@lex111 when I run npm run start, this fix seems to be working. but when I do an npm run build followed npm run serve it's still broken.

facebook-github-bot pushed a commit to facebook/relay that referenced this issue Jun 3, 2021
Summary:
Docusaurus beta 0 has been released so let's use it!

Also, you are currently affected by an annoying regression in a Docusaurus transitive dependency (cssnano@5.0.3 => facebook/docusaurus#4826)

Reported by christianvuerings here: #3469 (comment)

![image](https://user-images.githubusercontent.com/749374/120523199-ed342500-c3d5-11eb-9971-71d7106f1843.png)

This should now be fixed by re-generating the lockfile.

Pull Request resolved: #3505

Reviewed By: kassens

Differential Revision: D28874560

Pulled By: rbalicki2

fbshipit-source-id: 6baece255be570abd5ec5f19f10e7f503be482f9
@rrdelaney
Copy link

Also still happening to me 馃槙

@slorber
Copy link
Collaborator

slorber commented Jun 9, 2021

@rrdelaney you are using cssnano@5.0.3, please make sure it's not the case anymore.

A good way is to re-generate your lockfile by deleting it, it will pick a newer (non-buggy) cssnano version

@Josh-Cena Josh-Cena added external This issue is caused by an external dependency and not Docusaurus. and removed status: needs triage This issue has not been triaged by maintainers labels Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants