Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly html code syntax #4824

Closed
Andrew-web-coder opened this issue May 21, 2021 · 2 comments · Fixed by #4830
Closed

Ugly html code syntax #4824

Andrew-web-coder opened this issue May 21, 2021 · 2 comments · Fixed by #4830
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Andrew-web-coder
Copy link

Andrew-web-coder commented May 21, 2021

The issue

Ugly html code syntax and colors are different from the homepage

To Reproduce

  1. Open Docusaurus Playground

  2. Copy paste this snippet from https://github.com/facebook/docusaurus/blob/master/website/docusaurus.config.js

    prism: {
      theme: require("prism-react-renderer/themes/github"),
      darkTheme: require("prism-react-renderer/themes/dracula")
    },
    
  3. Add some html code in docs

Expected behavior

To have the same colors as here - https://docusaurus.io/docs/markdown-features/tabs

Reproducible Demo

https://codesandbox.io/s/loving-heyrovsky-f76no?file=/docs/intro.md - open docs -> intro for sample html - it is ugly!!!

@Andrew-web-coder Andrew-web-coder added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels May 21, 2021
@Josh-Cena
Copy link
Collaborator

This is not just an HTML snippet issue, but a general problem for the prism github theme. The same thing happens for languages like bash—the attr-name highlight color doesn't look right.

@lex111
Copy link
Contributor

lex111 commented May 21, 2021

Thanks for the report, this caused by new version of prism-react-renderer (see FormidableLabs/prism-react-renderer#100 for more details), so we locked its version to 1.1.1.

@Josh-Cena Josh-Cena removed the status: needs triage This issue has not been triaged by maintainers label Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants