Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot is throwing high-severity warnings on version of immer - warning pasted below #4191

Closed
bumblefudge opened this issue Feb 7, 2021 · 2 comments · Fixed by #4270
Closed
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.

Comments

@bumblefudge
Copy link

Dependabot cannot update immer to a non-vulnerable version
The latest possible version that can be installed is 1.10.0 because of the following conflicting dependencies:

@docusaurus/core@2.0.0-alpha.70 requires immer@1.10.0 via a transitive dependency on react-dev-utils@10.2.1
@docusaurus/preset-classic@2.0.0-alpha.70 requires immer@1.10.0 via a transitive dependency on react-dev-utils@10.2.1
The earliest fixed version is 8.0.1.

View logs or learn more about troubleshooting Dependabot errors.

1 immer vulnerability found in yarn.lock 14 days ago
Remediation
Upgrade immer to version 8.0.1 or later. For example:

immer@^8.0.1:
version "8.0.1"
Always verify the validity and compatibility of suggestions with your codebase.

Details
CVE-2020-28477
high severity
Vulnerable versions: < 8.0.1
Patched version: 8.0.1
Overview
Affected versions of immer are vulnerable to Prototype Pollution.

Proof of exploit
const {applyPatches, enablePatches} = require("immer");
enablePatches();
let obj = {};
console.log("Before : " + obj.polluted);
applyPatches({}, [ { op: 'add', path: [ "proto", "polluted" ], value: "yes" } ]);
// applyPatches({}, [ { op: 'replace', path: [ "proto", "polluted" ], value: "yes" } ]);
console.log("After : " + obj.polluted);
Remediation
Version 8.0.1 contains a fix for this vulnerability, updating is recommended.

@bumblefudge bumblefudge added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Feb 7, 2021
@lex111
Copy link
Contributor

lex111 commented Feb 7, 2021

Related PR: facebook/create-react-app#10412

@slorber
Copy link
Collaborator

slorber commented Feb 8, 2021

see also #4093

I think @yangshun reported internally at FB that we are waiting for this CRA fix

@Josh-Cena Josh-Cena added external This issue is caused by an external dependency and not Docusaurus. and removed status: needs triage This issue has not been triaged by maintainers labels Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants