Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): Add a missing whitespace before prompt to use npm run serve #3188

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Aug 1, 2020

Motivation

We should always have a whitespace after the period when there is a following sentence.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See CI logs to confirm that the whitespace is there.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 3c97bf3

https://deploy-preview-3188--docusaurus-2.netlify.app

@SamChou19815 SamChou19815 marked this pull request as ready for review August 1, 2020 18:25
@yangshun yangshun merged commit 5c3a007 into master Aug 2, 2020
@yangshun yangshun added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 2, 2020
@yangshun yangshun deleted the add-missing-whitespace branch August 26, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants