fix(v1): consistent slug & hash-link generation #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 7517450 |
|
Deploy preview for docusaurus-preview ready! Built with commit 7517450 |
yangshun
approved these changes
Nov 20, 2019
|
Trying to reduce number of issues open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #2008
Close #1877
Close #1939
Use GitHub slugger npm package like in v2, because its more consistent and is correct rather than our legacy slug function. According to our site. Its also consistent with v2
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Right TOC and markdown hash link is the same in which it wasn't previously
Updated tests because that's how GitHub generates the anchors https://gist.github.com/endiliey/a08deae18ed944d5e95e32f219decc98#hello----world