Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs according to lint-staged v10 #8394

Merged
merged 1 commit into from Jan 31, 2020
Merged

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Jan 29, 2020

According to lint-staged v10 changelog (https://github.com/okonet/lint-staged#v10):

From v10.0.0 onwards any new modifications to originally staged files will be automatically added to the commit. If your task previously contained a git add step, please remove this. The automatic behaviour ensures there are less race-conditions, since trying to run multiple git operations at the same time usually results in an error.

There's no need to specify git add on the config anymore. So it should be removed from the doc as well.

According to lint-staged v10 changelog (https://github.com/okonet/lint-staged#v10):

> From `v10.0.0` onwards any new modifications to originally staged files will be automatically added to the commit. If your task previously contained a `git add` step, please remove this. The automatic behaviour ensures there are less race-conditions, since trying to run multiple git operations at the same time usually results in an error.

There's no need to specify `git add` on the config anymore. So it should be removed from the doc as well.
@oluoluoxenfree
Copy link

Looks good to me and @amyrlam. @iansu what do you think?

@ianschmitz ianschmitz added this to the 3.3.1 milestone Jan 31, 2020
@ianschmitz ianschmitz changed the title Update doc according to lint-staged v10 Update docs according to lint-staged v10 Jan 31, 2020
@ianschmitz ianschmitz merged commit 03018d7 into facebook:master Jan 31, 2020
@ianschmitz
Copy link
Contributor

Looks good. Thanks!

@lukyth lukyth deleted the patch-1 branch February 4, 2020 04:26
@lock lock bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants