Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated docs regarding vscode eslint extension and typescript autofix #8307

Merged
merged 2 commits into from Jan 30, 2020
Merged

Conversation

john-james-gh
Copy link
Contributor

@john-james-gh john-james-gh commented Jan 10, 2020

I would like to remove documentation that is no longer relevant (outdated). It is regarding ESLint extension for Visual Studio Code and its Typescript support. microsoft/vscode-eslint#609

Before ESLint extension version 2.0.4 (before December 16, 2019 source:
https://github.com/microsoft/vscode-eslint/releases), the extension did not have Typescript support (auto-fix feature) enabled by default and it had to be enabled manually by adding a specific configuration in .vscode/settings.json (the block removed by this PR)

As aforesaid, this issue with ESLint not having TypeScript support enabled by default has been fixed with version 2.0.4 (released on Dec 16, 2019) and this block of code (workaround) is no longer relevant.
Capture source: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

In fact this configuration is now squiggle-lined once added to .vscode/settings.json with a warning as shown in the screenshot.

Screenshot (31)

@facebook-github-bot
Copy link

Hi alex-vukovity-cko! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@john-james-gh john-james-gh changed the title remove outdated docs regarding vscode eslint extension and typescript autofix Remove outdated docs regarding vscode eslint extension and typescript autofix Jan 10, 2020
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.3.1 milestone Jan 30, 2020
@ianschmitz ianschmitz merged commit dd0df73 into facebook:master Jan 30, 2020
@ianschmitz
Copy link
Contributor

Thanks!

SamChou19815 added a commit to cornell-dti/trends-in-web-dev-website that referenced this pull request Jan 31, 2020
SamChou19815 added a commit to cornell-dti/trends-in-web-dev-website that referenced this pull request Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants