Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sass importLoaders #8281

Merged
merged 1 commit into from Jan 30, 2020
Merged

Conversation

mariusc23
Copy link
Contributor

@mariusc23 mariusc23 commented Jan 3, 2020

This PR fixes the importLoaders setting for sass files. I believe this was broken in #5829 when an additional loader was introduced but the importLoaders setting was not incremented.

I ran into this trying to upgrade react-scripts locally. Verified this change fixes it for our project.

This is the error I ran into:

Error: resolve-url-loader: CSS error
  file:///MySassFile.module.scss:42:6: Unknown word
You tried to parse SCSS with the standard CSS parser; try again with the postcss-scss parser
  You tried to parse SCSS with the standard CSS parser; try again with the postcss-scss parser
    at runMicrotasks (<anonymous>)

@facebook-github-bot
Copy link

Hi mariusc23! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.4 milestone Jan 30, 2020
@ianschmitz ianschmitz closed this Jan 30, 2020
@ianschmitz ianschmitz reopened this Jan 30, 2020
@ianschmitz ianschmitz modified the milestones: 3.4, 3.3.1 Jan 30, 2020
@ianschmitz ianschmitz merged commit e530598 into facebook:master Jan 30, 2020
@ianschmitz
Copy link
Contributor

Thanks!

tux-tn pushed a commit to DocSpring/craco-less that referenced this pull request Jan 31, 2020
ImportLoaders setting has been changed in react-scripts 3.3.1 (facebook/create-react-app#8281)
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants