Replace favicon in templates #8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianschmitz
approved these changes
Dec 17, 2019
The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors. Closes facebook#7957
heyimalex
force-pushed
the
inverted-favicon
branch
from
e0567e4
to
c78357a
Compare
|
The prior favicon was small because it used embeded pngs instead of bmps. I couldn't find a way to combine a bunch of pngs into an ico so I wrote one. Pretty annoying, but all of the original embedded sizes are accounted for. Here's the source png if anyone has a better way.
|
mrmckeb
approved these changes
Dec 19, 2019
|
Looks great @heyimalex, happy for you to merge ;) |
This was referenced Feb 22, 2020
This was referenced Mar 8, 2020
This was referenced Mar 11, 2020
This was referenced Mar 18, 2020
|
The inverted comments look a bit odd IMO. I'm not a designer though. |
gaearon
added a commit
that referenced
this pull request
Apr 28, 2020
|
I'm going to revert this. I'd prefer to be involved in any discussion that involve branding (logo, icons). This stuff matters and ideally someone with design background should be involved in upgrading or changing these. I empathize with the original problem but this solution isn't quite good enoungh. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors.
Closes #7957
Here's an example of how it looks in light and dark browsers:
I honestly have no idea why the size grew 5x and I'm going to try and figure out why.