Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-runner note to readme #8132

Merged
merged 2 commits into from Dec 15, 2019
Merged

Add package-runner note to readme #8132

merged 2 commits into from Dec 15, 2019

Conversation

JeromeDeLeon
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link

Hi JeromeDeLeon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

iansu
iansu suggested changes Dec 10, 2019
View reviewed changes
README.md Outdated
@@ -61,7 +62,7 @@ _`npm init <initializer>` is available in npm 6+_
yarn create react-app my-app
```

_`yarn create` is available in Yarn 0.25+_
_`yarn create <initializer>` is available in Yarn 0.25+_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the yarn create docs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@iansu iansu added this to the 3.3.1 milestone Dec 15, 2019
@iansu iansu merged commit f314855 into facebook:master Dec 15, 2019
@iansu
Copy link
Contributor

iansu commented Dec 15, 2019

Thanks!

@JeromeDeLeon JeromeDeLeon deleted the patch-1 branch December 16, 2019 03:15
@lock lock bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iansu iansu iansu requested changes

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeromeDeLeon @facebook-github-bot @iansu