Remove error for @typescript-eslint/no-namespace #7803
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
szhu
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
@heyimalex can you please take a look at this one? Looks good to me, based on the conversation you had in the related issue. |
|
Double checked that the typescript test works with declare, fails without declare, which is what you would expect. This is good to go. |
|
Great, thank you! I don't see a merge button -- let me know if anything else is needed on my end to merge this. |
|
Hey @heyimalex, just wanted to check in again to see if there is any action waiting on me before this is merged. |
Fixes #7651
Haven't tested it yet, if someone can do that then that would be great!