Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS / SSL config seems wrong #8882

Closed
ORESoftware opened this issue Apr 22, 2020 · 6 comments
Closed

HTTPS / SSL config seems wrong #8882

ORESoftware opened this issue Apr 22, 2020 · 6 comments

Comments

@ORESoftware
Copy link

ORESoftware commented Apr 22, 2020

I am following the directions here:
https://create-react-app.dev/docs/using-https-in-development/

I am running this:

HTTPS='true' \
SSL_CRT_FILE='certs/localhost/server.crt' \
SSL_KEY_FILE='certs/localhost/server.key' \
react-scripts start

unfortunately the cert is not showing the expected org and unit information:

Screenshot from 2020-04-22 12-04-17

my cert generation process checks out, since I have a golang server that uses this:

        certFilePath := path.Join(proj.ProjectRoot, "/certs/localhost/server.crt")
        keyFilePath := path.Join(proj.ProjectRoot, "/certs/localhost/server.key")
        log.Fatal(s.ServeTLS(l, certFilePath, keyFilePath))

and I get this:

Screenshot from 2020-04-22 12-20-51

so I wonder if there is a difference in how the certs are being used by CRA+node.js vs golang?

@ORESoftware
Copy link
Author

I saw some instructions to copy the cert:

cat certs/localhost/server.key > node_modules/webpack-dev-server/ssl/server.pem

but when I then run:

PORT=3015 HTTPS='true' \
    SSL_CRT_FILE='certs/localhost/server.crt' \
    SSL_KEY_FILE='certs/localhost/server.key' \
    react-scripts start

I get:

error:0909006C:PEM routines:get_name:no start line

awful

@ORESoftware
Copy link
Author

this does seem to be a bug - I have a workaround as described here:
#6126 (comment)

@stale
Copy link

stale bot commented May 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 25, 2020
@ORESoftware
Copy link
Author

bump

@stale stale bot removed the stale label May 25, 2020
@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 26, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

@stale stale bot closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant