Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevServer on IE: WebSocket compatibility #8150

Closed
josias-r opened this issue Dec 11, 2019 · 3 comments
Closed

DevServer on IE: WebSocket compatibility #8150

josias-r opened this issue Dec 11, 2019 · 3 comments
Labels
issue: bug report needs triage

Comments

@josias-r
Copy link

josias-r commented Dec 11, 2019 •
edited

Sorry to bother about IE support 馃槆

Describe the bug

In react-scripts 3.3.0 de webPackDevServer setup was switched from SockJS to WebSocket. see PR
Since the url.format returns an URL something like ws:localhost not ws://localhost, it will throw an Syntax Error on IE.

Environment

Windows 8.1, node 10, npm 6, ie11

Steps to reproduce

  1. Install create-react-app w/ react-scripts 3.3.0
  2. Import react-app-polyfills (stable & ie11)
  3. Set browserslist to include "IE 11" in development mode aswell
  4. Run npm start
  5. Open the dev server in IE

Expected behavior

The dev-server should work on IE aswell.

Actual behavior

A syntax error gets thrown.
@goto1
Copy link

goto1 commented Dec 11, 2019 •
edited

This is related to #8084

@josias-r
Copy link
Author

@goto1 Ah yes, I didn't see that ticket before. I was referring to the missing slashes: true property.
Maybe close as a dupe?

@josias-r
Copy link
Author

Fixed in this PR

@lock lock bot locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug report needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josias-r @goto1