Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong webpack cfg condition: sourceMap: isEnvProduction && shouldUseSourceMap #7632

Closed
mixalbl4-127 opened this issue Sep 3, 2019 · 1 comment

Comments

@mixalbl4-127
Copy link

Describe the bug

Here: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/webpack.config.js
wrong condition: sourceMap: isEnvProduction && shouldUseSourceMap
correct condition: sourceMap: isEnvDevelopment && shouldUseSourceMap

Why?
SourceMaps needs in Dev mode, in Prod it must be always disabled. But this condition enable Style Source Maps ONLY in PROD + shouldUseSourceMap, in all other situations it will be False

Research results:

  1. this issue because of this bug
@heyimalex
Copy link
Contributor

We intentionally only make sourcemaps for production builds for various reasons, but that issue should be looked at again.

@lock lock bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants