-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer dependency issue between Create-React-App and Storybook #6344
Comments
Hi @VincentLanglet, this has been reported before as you mentioned. I'm currently working on a PR with Storybook to resolve this properly. |
@mrmckeb Yes i saw that, a big thanks to you for working on it. But I still wonder why it's not possible for For example, in my package.lock I have two
Why is it different with |
I don't have storybook installed and I see this error as well. It seems there is a strict match for both
|
Hi @gcallaghan, that's odd, thanks for raising. Those projects should definitely be aligned, and realistically, we could resolve babel-loader from |
@gcallaghan your |
I'll run yarn upgrade on my react-scripts now and see if that fixes it. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
@gcallaghan did upgrading your react-scripts solve the issue? I'm having this same problem. |
@mkay581 At the time yes, but my understanding is type of issue with CRA happens from time to time due to transitive dependencies. Unfortunately I don't have the github issue or thread handy. |
Hi there, newer releases of Storybook will use your Let us know if you have any other issues! |
Thanks! can you add a link to the discussion thread? Or link to the Storybook PR that fixes it? I'm curious to know what the fix is and when it will be available. |
@mkay581, I fixed this over at Storybook itself - take a look at the preset for |
I previously asked a question about the warning about unmeet peer dependency here: #6134
I had the answer
these are just warnings and nothing to worry about
.Unfortunately now I have errors:
When I install
"@storybook/react"
and run"storybook": "start-storybook -p 9009 -s public"
,I get
Error: Cannot find module 'babel-loader/package.json' from ...
But if I install
babel-loader
, and run"start": "react-scripts start"
, I getOf course, it's fixable if I install the exact version "8.0.4". Like explains here storybookjs/storybook#5183
But shouldn't
create-react-app
re-think about the way dependencies are used ?I don't know a lot about how it works. But why
react-script
version can't use his dependencies version and let other dependencies to use their ?The text was updated successfully, but these errors were encountered: