Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting documentation to Docusaurus #5238

Closed
19 of 20 tasks
selbekk opened this issue Oct 2, 2018 · 24 comments
Closed
19 of 20 tasks

Porting documentation to Docusaurus #5238

selbekk opened this issue Oct 2, 2018 · 24 comments

Comments

@selbekk
Copy link
Contributor

selbekk commented Oct 2, 2018

Ref #5209, this issue will work as a base for planning the work of creating a Docusaurus documentation website for create-react-app.

Task list

An initial task overview might look like this:

This task list will be updated, edited and changed as we come up with more tasks, or split larger ones up into smaller ones.

Documentation structure

There are many ways of structuring the content found in this repo, but I think a good first approach is to split it into two parts:

  • Getting started (some of the information from the README.md file can go here)
  • User Guide (as is, for now)

From there, we can split it up into more narrow "groups", if we find it appropriate and helpful for the user.

@gaearon
Copy link
Contributor

gaearon commented Oct 2, 2018

This makes sense. I think we should figure out a good high-level structure for User Guide before diving into this work. We'd want to group it into higher level sections.

@selbekk
Copy link
Contributor Author

selbekk commented Oct 2, 2018

That's fine by me. 🙂 You can do some thinking on that while I start with some of the more "get-it-done"-tasks? :)

@selbekk
Copy link
Contributor Author

selbekk commented Oct 2, 2018

Challenge: Docusaurus requires a /docs folder on the root scope of the project - but I understand if you want to hold off on creating one to not mislead your users while we set this up.

@Timer
Copy link
Contributor

Timer commented Oct 2, 2018

Adding a top level /docs section is fine. Just add a README.md pointing to normal user guide for now.

@gaearon
Copy link
Contributor

gaearon commented Oct 8, 2018

A few concerns before we launch this for the first time.

  • We'll need to make the front page copywriting more compelling. Some tools specifically use "no need to eject" as a selling point these days. We should adapt and try to explain the benefits of CRA approach — specifically, easy updates. That's something I can work on just after everything else is ready and before we publish.

  • There's probably some project-specific branding we should do. Like choosing a color palette and having a separate logo. For now it's fine though, we can add it later.

  • How-to section is too long and is a mix of everything. We should try to further split it into separate sections grouped by some common topic. E.g. "Styles and Assets", "Backend Integration". I also don't like "How-to" as a title.

  • Long page titles like "Generating Dynamic <meta> Tags on the Server" look bad in sidebar. We should shorten them, e.g. "Title and Meta Tags" which can unify both topics.

  • Testing and Deployment sections should probably come before more esoteric tasks.

  • "Updating to new releases" should be somewhere much earlier.

  • Avoid tiny pages. If a page is tiny it can be probably unified with some other page.

  • There's "API reference" in sidebar, remove?

@selbekk
Copy link
Contributor Author

selbekk commented Oct 9, 2018

So most of this is done, with the exception of copywriting and branding things.

@selbekk
Copy link
Contributor Author

selbekk commented Oct 11, 2018

We should probably make the docs searchable as well, but I think we can release this as is now.

@amyrlam has done some research here. We need to configure Docusaurus and then we need to set up Algolia's DocSearch.

The latter, which will create an API key, is probably best done by one of the maintainers. Once it's done, send me the API key, and I'll create a pull request enabling the search feature.

@amyrlam
Copy link
Contributor

amyrlam commented Oct 20, 2018

Really awesome this is out! Docusaurus folks are super excited!

@gaearon
Copy link
Contributor

gaearon commented Oct 20, 2018

Bring in ~last few weeks of edits to README to /docusaurus

I did that. I also truncated the generated README to be very short although we can still make it shorter.

@amyrlam
Copy link
Contributor

amyrlam commented Oct 20, 2018

Ah sorry about that - makes sense now. The README seems good as-is! Updated my comment and other checkboxes above.

Do you still want to add Algolia search? Could be a quick win. CRA team will need to sign up https://community.algolia.com/docsearch/who-can-apply.html to get the API key.

Docusaurus has already added CRA as a user 😄: facebook/docusaurus#1050

@gaearon
Copy link
Contributor

gaearon commented Oct 20, 2018

CRA team will need to sign up https://community.algolia.com/docsearch/who-can-apply.html to get the API key.

You're a part of the team now, so maybe you could do it? :-)

@amyrlam
Copy link
Contributor

amyrlam commented Oct 20, 2018

Ok cool - sure thing, I'll do that

@gaearon
Copy link
Contributor

gaearon commented Oct 20, 2018

We also need to set up docs to release from CI.

@amyrlam
Copy link
Contributor

amyrlam commented Oct 20, 2018

Submitted to Algolia - sounds like may take a few days. Should be a straightforward PR!

//

As for setting up docs to release from CI...not super familiar with GitHub Pages or Appveyor but took a stab at it here: #5496 (work in progress)

Let me know if you have any ideas to help move forward. Also if you could fill in some of the git stuff. TIL the skip_commits was why Appveyor wasn't running on the docusaurus branch.

@petetnt
Copy link
Contributor

petetnt commented Oct 23, 2018

This is awesome, nice work!!

Something that would be eventually nice would be versioning the docs like the React ones are and pointing the versioned docs in the template generated by CRA 👍

@endiliey
Copy link
Contributor

Hello 👋

Docusaurus maintainer here. Really happy to see this happening. Thanks for doing this to all people involved. ☺

endiliey referenced this issue in algolia/docsearch-configs Oct 24, 2018
@amyrlam
Copy link
Contributor

amyrlam commented Oct 24, 2018

@petetnt 👋 Was thinking of waiting to version docs til https://github.com/facebook/docusaurus v2.0 is out. But if there are a lot of changes, could start versioning docs? Would be good to get the docs on continuous deployment first...

//

Here's the Algolia PR, woot: #5551

@iansu
Copy link
Contributor

iansu commented Oct 24, 2018

Versioning is probably something we'll want eventually. I created an issue so we don't forget about this: #5560

@peterbe
Copy link

peterbe commented Oct 25, 2018

Since this issue is still open, I thought I'd pile on...:

http://bit.ly/CRA-PWA is mentioned in many places. It's now wrong.

It redirects to https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#making-a-progressive-web-app. But it should redirect to https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app instead.

Who has the keys to that bit.ly account?

@peterbe
Copy link

peterbe commented Oct 25, 2018

@selbekk Can you add my point (comment right above) about the bit.ly link redirect to your todo list in the issue description?

@petetnt
Copy link
Contributor

petetnt commented Oct 25, 2018

@peterbe check out #5536

@endiliey
Copy link
Contributor

Seems that CI is not yet setup for CRA documentation.

@stale
Copy link

stale bot commented Nov 26, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 26, 2018
@selbekk
Copy link
Contributor Author

selbekk commented Nov 26, 2018

I guess this issue could be closed now. Thanks for all participating members!

@selbekk selbekk closed this as completed Nov 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants