Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: react-scripts 4 no eslint warnings anymore #10540

Closed
josias-r opened this issue Feb 10, 2021 · 1 comment
Closed

Bug: react-scripts 4 no eslint warnings anymore #10540

josias-r opened this issue Feb 10, 2021 · 1 comment

Comments

@josias-r
Copy link

React version: 16.13.1

Steps To Reproduce

Upgrade to react-scripts 4

The current behaviour

No eslint warnings are being displayed inside the terminal as they used to. (errors work fine)

React-scripts thinks everything is fine
Screenshot 2021-02-10 at 12 30 33
But running eslint manually shows that some warnings are still present
Screenshot 2021-02-10 at 12 30 42

Not sure if this is connected to the bug, but 2 of the warnings should actually be ignored because of an // eslint-disable-line comment, but for some reason they still get reported.

I've no clue what's going on. I checked the changelogs and saw nothing of cra disabling the warnings on purpose. I made sure the correct eslintrc file is used. Is there something I'm missing? 🤷🏻‍♂️

Edit: Just quickly tested with a fresh cra install if the same behaviour is happening. And yes, npx create-react-app my-app --template typescript resulted in the same behaviour. I added a variable and never used it, which will show a "variable never used" warning, and car reported nothing in the terminal. Is this behaviour intended? If so, is there a way to enable warnings again? 😁

The expected behaviour

Eslint warnings should still appear in the terminal.

@gaearon gaearon transferred this issue from facebook/react Feb 11, 2021
@josias-r
Copy link
Author

Just found this ticket. My ticket is a duplicate, closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant