Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip_file prelude rule partially exported #637

Open
benbrittain opened this issue May 3, 2024 · 2 comments
Open

zip_file prelude rule partially exported #637

benbrittain opened this issue May 3, 2024 · 2 comments

Comments

@benbrittain
Copy link
Contributor

The prelude rule for zip_file looks like it's been partially exported.

It looks like the toolchain target that is used internal to Meta is called fbsource//xplat/buck2/platform/zip_file:zip_file. I'm pretty sure the rule can't be used without it, the arguments don't refer to a zip tool I'm aware of. I'd guess it's a python wrapper around the zip tool itself.

@JakobDegen
Copy link
Contributor

The tool that our toolchain points to is this one. I could hypothetically copy that into the prelude and claim that you're now better supported, but that would require a bootstrap java toolchain or something like that which is a road I really don't think we want to go down in the prelude. You of course still have the option to do that in your own repo if you like.

Probably someone should rewrite that thing into python (or even better, modify the rule to just accept a standard zip tool).

@benbrittain
Copy link
Contributor Author

Probably the zip rules should be removed then? They are just kinda api noise for open source if they aren't functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants