-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java rules don't appear to be usable in OSS edition of buck2 #627
Comments
Yeah, that's correct. Java rules are not yet properly supported unfortunately |
That’s too bad. Can you shed some light on why? What kind of use cases does meta have for which the jre alone isn’t sufficient to build everything you need to build? |
Disclaimer: I don't work at meta, I don't actually know what goes on upstream. My understanding is that the prelude shipping here is a subset of the actual prelude meta uses, with stuff that relies on their infra ripped out. If Java rules aren't working, I imagine the parts that are needed to make it work are meta-specific, and therefore, haven't ended up here. It does mean that folks can make them work, and then send PRs to fix it, but it's not going to be a drop-in experience like with other languages. |
Yea, I understand that. In this case, the first error I ran into is that there is a tool missing. The tool has command line arguments like |
I tried to use
java_binary()
. I was pretty quickly hit with an error about one of my provider fields (JavaToolchainInfo.fat_jar
) being unset, so I looked into what it might be expecting, and found this.buck2/prelude/java/java_binary.bzl
Lines 40 to 48 in d458e16
Whatever tool this is doesn't appear to be a standard JRE tool, and I suspect it's a Meta internal tool. Which means all of the Java rules don't work outside of Meta. Is my hunch correct about this, or is there a way to get this tool?
The text was updated successfully, but these errors were encountered: