Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livewire component discovery solution. #319

Merged
merged 6 commits into from Oct 14, 2020

Conversation

ArnaudLier
Copy link
Contributor

No description provided.

Copy link
Collaborator

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks. Could you add a screenshot in the comments of how this solution looks like? Thanks!

@ArnaudLier
Copy link
Contributor Author

image
How it looks ^

@freekmurze freekmurze merged commit 614bc70 into facade:master Oct 14, 2020
@freekmurze
Copy link
Collaborator

Thank you!

AlexVanderbist pushed a commit to Synchro/ignition that referenced this pull request Oct 27, 2020
* Create LivewireDiscoverSolution.php

* Create MissingLivewireComponentSolutionProvider.php

* Update IgnitionServiceProvider.php

* Update MissingLivewireComponentSolutionProvider.php

* Update LivewireDiscoverSolution.php

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants