fix: properly bind singleton #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mfn
reviewed
Aug 3, 2020
Comment on lines
-29
to
+31
| $this->app->singleton(MultiDumpHandler::class, $multiDumpHandler); | ||
| $this->app->singleton(MultiDumpHandler::class, function () use ($multiDumpHandler) { | ||
| return $multiDumpHandler; | ||
| }); |
There was a problem hiding this comment.
Couldn't this just be ?
$this->app->instance(MultiDumpHandler::class, $multiDumpHandler);This would be also more clearly convey the intend here. The closure factory looks redundant.
There was a problem hiding this comment.
yeah, i always forget about instance -- both should have the same effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #290
馃憢 You may want to consider bringing in psalm to help ya out!
The typehint for
Container::singletonis@param \Closure|string|null $concretehttps://github.com/laravel/framework/blob/7.x/src/Illuminate/Container/Container.php#L352