Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DumpHandler instance manually in DumpRecorder::register() #286

Merged
merged 1 commit into from Jul 13, 2020
Merged

Make DumpHandler instance manually in DumpRecorder::register() #286

merged 1 commit into from Jul 13, 2020

Conversation

tzurbaev
Copy link
Contributor

As described in #275, $this->app->make() call on DumpHandler overrides singleton instance of Application class and this breaks any calls to Application::getNamespace() method after dumping something in tests.

@freekmurze freekmurze merged commit 7329a04 into facade:master Jul 13, 2020
@freekmurze
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tzurbaev @freekmurze