Change DumpRecorder dependency to use contract instead of Application. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
approved these changes
Jan 30, 2020
|
Seems good to me. Do you see a problem with this @mpociot? |
mpociot
approved these changes
Mar 6, 2020
|
Looks good 👍 |
|
Thanks! |
|
@filipac @freekmurze @mpociot we're actually working on an official plugin to integrate with Ignition right now (https://github.com/rainlab/ignition-plugin) and we've fixed this in the core October build (octobercms/library@e33163d), since 2.0 isn't usable for October CMS as we only ever follow LTS releases of Laravel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to add Ignition to an OctoberCms application and so far the only thing that stops this is the hard-coded dependency to Illuminate\Foundation\Application instead of Illuminate\Contracts\Foundation\Application - because October changes the application instance with a custom one that implements the Contract.