Add indicator that solution is running #212
Merged
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good thing to have built in, any issue preventing the merge? |
freekmurze
approved these changes
Jan 3, 2020
|
Ok for me. @sebastiandedeyne can this get your blessing too? |
sebastiandedeyne
approved these changes
Jan 6, 2020
|
Looks good to me! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using long-running solutions, there is currently no indication that the solution is running in the background.
Example: asset is missing, solution is to compile assets, and that takes a few seconds
This ensures that the user knows that the solution is running. Also prevents solutions to be run multiple times by pressing the button multiple times.
I'm no vue expert so hopefully the implementation is alright, let me know if i need to change anything :)