Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default serialization of time types #5960

Closed
shawkins opened this issue Apr 26, 2024 · 0 comments · Fixed by #5962
Closed

Change default serialization of time types #5960

shawkins opened this issue Apr 26, 2024 · 0 comments · Fixed by #5962
Assignees
Labels
component/crd-generator Related to the CRD generator
Milestone

Comments

@shawkins
Copy link
Contributor

Given the recent changes to use jackson to produce the crd types for java / javax classes that have jackson overrides, we should use mapper.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS) by default - that will generate the most expected from of the crds.

This could be considered a breaking change, but previously the mapping that was generated was object and not usable at all, so we should be free to make this change as a bug fix.

If there are objections to making this change in 6.x, the new crd generator will allow for an ObjectMapper to be passed in that has this configuration.

@shawkins shawkins added the component/crd-generator Related to the CRD generator label Apr 26, 2024
@shawkins shawkins added this to the 6.13.0 milestone Apr 26, 2024
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 26, 2024
closes: fabric8io#5960

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins shawkins self-assigned this Apr 26, 2024
manusa pushed a commit that referenced this issue Apr 29, 2024
closes: #5960

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/crd-generator Related to the CRD generator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant