Default owner reference blockOwnerDeletion to true

[shawkins]

Is your enhancement related to a problem? Please describe

Relates to operator-framework/java-operator-sdk#2318 - the fabric8 logic is currently defaulting to null. the operator sdk is ok if the default behavior changes in fabric8. They don't expect that behavior will need to be configurable.

Describe the solution you'd like

For the fabric8 ownerReference creation method to default blockOwnerDeletion to true - that matches the default expected behavior of kubernetes.

Describe alternatives you've considered

No response

Additional context

No response

[rohanKanojia]

@shawkins : Is this issue related to Kubernetes Model? Or do we want to accommodate null value for blockOwnerDeletion while handing it in KubernetesClient?

[csviri]

If some will need this to be configurable, we can just override it on our side. But having this defaulted to true is probably the expected way to go IMO.

[shawkins]

Is this issue related to Kubernetes Model? Or do we want to accommodate null value for blockOwnerDeletion while handing it in KubernetesClient?

@rohanKanojia This is referring to the HasMetadata.addOwnerReference helper method, it's defaulting to null but true would be a better choice.

[manusa]

Would this be a breaking change? i.e. can we add this in 6.13, seems like low hanging fruit.

[shawkins]

Strictly speaking yes, but practially speaking no - it's what users should want by default.