Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDGenerator: Add support for Meta-Annotations/Combined-Annotations #5823

Open
baloo42 opened this issue Mar 20, 2024 · 3 comments
Open

CRDGenerator: Add support for Meta-Annotations/Combined-Annotations #5823

baloo42 opened this issue Mar 20, 2024 · 3 comments
Labels
component/crd-generator Related to the CRD generator
Milestone

Comments

@baloo42
Copy link
Contributor

baloo42 commented Mar 20, 2024

Is your enhancement related to a problem? Please describe

At the moment the CRDGenerator does not support Meta-Annotations / Combined-Annotations.

Describe the solution you'd like

A user of the CRDGenerator should be able to combine the existing CRDGenerator annotations in own annotations.
The CRDGenerator must detect those indirect usages and must generate the CRDs in the same way as it would if the CRDGenerator annotations are used directly.

Describe alternatives you've considered

No response

Additional context

An overview what Meta-Annotations/Combined-Annotions are can be found here:
https://dzone.com/articles/what-are-meta-annotations-in-java

Some other frameworks support such kind of a feature, too:

@rohanKanojia
Copy link
Member

cc @andreaTP

@andreaTP
Copy link
Member

andreaTP commented Apr 2, 2024

Thanks for bringing this up @baloo42 !

As mentioned on the related issue:

I would love to see a strawman on how we can leverage this feature.
If I understand the problem space correctly with meta-annotations we should be able to combine, for example, io.fabric8.generator.annotation.Max with org.hibernate.validator.Max

I'm supportive of this but we need a little design phase before starting to crunch code.

@baloo42
Copy link
Contributor Author

baloo42 commented Apr 2, 2024

I agree, this topic requires much more details before we start to get an overview if it's really worth the efforts. Some notes:

  • We should define some goals and none-goals.
  • We should add some examples to explain what we want to achieve.
  • We should collect / create some examples how we can solve resolving those meta annotations with sundrio.

@manusa manusa added the component/crd-generator Related to the CRD generator label May 2, 2024
@manusa manusa added this to the 7.x milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/crd-generator Related to the CRD generator
Projects
None yet
Development

No branches or pull requests

4 participants