Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share openshift tokens across openshift clients #4701

Closed
shawkins opened this issue Dec 20, 2022 · 2 comments
Closed

Share openshift tokens across openshift clients #4701

shawkins opened this issue Dec 20, 2022 · 2 comments

Comments

@shawkins
Copy link
Contributor

If the adapt call is made multiple times, this will create different OpenShiftOAuthInterceptors - each will maintain it's own token.

Originally posted by @shawkins in #4673 (comment)

@shawkins
Copy link
Contributor Author

This affects usage where the user needs an openshift client, but initially is provided with just the base kuberenetes client. This should not be typical. It's more likely that the instance is already an openshift client, which is also the workaround to this issue - make sure the root client that is passed around is the openshift client.

@shawkins
Copy link
Contributor Author

Resolved via #4698 - we may revisit this so that a direct config value is not used for this sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant