Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crd-generator] Fix float support #4581

Merged
merged 1 commit into from Nov 23, 2022
Merged

[crd-generator] Fix float support #4581

merged 1 commit into from Nov 23, 2022

Conversation

andreaTP
Copy link
Member

Description

Fix #4576

This is a straightforward implementation of the fix without using the format field yet.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.3.0 milestone Nov 23, 2022
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Nov 23, 2022
@manusa manusa merged commit 66ca558 into fabric8io:master Nov 23, 2022
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@manusa manusa manusa approved these changes

@sunix sunix sunix approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Support for "float" types in spec for CRD generator
5 participants
@andreaTP @metacosm @manusa @sunix @rohanKanojia