Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4365 correcting backoff interval #4473

Merged
merged 1 commit into from Oct 7, 2022
Merged

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 2, 2022

Description

I introduced a regression in #4365 with the refactoring of the exponential backoff - the interval was not carried forward.

Another, optional, change is to add exceptions that preserve for blocking request stacktraces - that seems better than just the underlying stacktrace which will just be from the httpclient layer.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Oct 5, 2022

tests are failing :(

@shawkins
Copy link
Contributor Author

shawkins commented Oct 5, 2022

tests are failing :(

Right, the exception wrapping is not fully baked.

also adding stacktraces for blocking request exceptions
@shawkins
Copy link
Contributor Author

shawkins commented Oct 5, 2022

@manusa should be better now.

@shawkins shawkins closed this Oct 6, 2022
@shawkins shawkins reopened this Oct 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.2.0 milestone Oct 7, 2022
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Oct 7, 2022
@manusa manusa merged commit 14cb945 into fabric8io:master Oct 7, 2022
manusa added a commit that referenced this pull request Oct 7, 2022
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants