Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.fromKubeconfig does not respect the result of method loadFromKubeconfig #4391

Closed
own-idea opened this issue Sep 6, 2022 · 6 comments

Comments

@own-idea
Copy link
Contributor

own-idea commented Sep 6, 2022

Is your enhancement related to a problem? Please describe

the method fromKubeconfig in Config class ignore the method loadFromKubeconfig result, it maybe inappropriate.

  public static Config fromKubeconfig(String context, String kubeconfigContents, String kubeconfigPath) {
    // we allow passing context along here, since downstream accepts it
    Config config = new Config();
    if (kubeconfigPath != null)
      config.file = new File(kubeconfigPath);
    loadFromKubeconfig(config, context, kubeconfigContents);
    return config;
  }

Describe the solution you'd like

we should throw exception when the method loadFromKubeconfig return false. Absolutely, the change is breaking.

Describe alternatives you've considered

No response

Additional context

No response

@own-idea own-idea changed the title Config.fromKubeconfig does not respect the method loadFromKubeconfig Config.fromKubeconfig does not respect the result of method loadFromKubeconfig Sep 6, 2022
@Jatinkhatri-hub
Copy link

Hi, I am new to open source and would like to work on this issue. Can you help me how to get started?

@own-idea
Copy link
Contributor Author

own-idea commented Sep 6, 2022

Hi, I am new to open source and would like to work on this issue. Can you help me how to get started?
you may see the comment

@Jatinkhatri-hub
Copy link

Thanks for your help.

@Jatinkhatri-hub
Copy link

Jatinkhatri-hub commented Sep 6, 2022

@own-idea I am not fully able to understand what the issue is can you describe the issue a little bit more? because I am new to all this.

@stale
Copy link

stale bot commented Dec 6, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Dec 6, 2022
@shawkins
Copy link
Contributor

shawkins commented Dec 6, 2022

Addressed as part of #4519

@shawkins shawkins closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants