Skip to content

waitUntilCondition resource too old exception #3271

Closed
@shawkins

Description

@shawkins
Contributor

I tried to do a waitUntilCondition call, that eventually errorred out with a resource too old exception. This seems to come from WatcherException isShouldRetry - it explicitly is false when there's an http gone exception.

It should either be the other way around, or to retry no matter what the exception is.

Activity

self-assigned this
on Jun 25, 2021
added a commit that references this issue on Jun 25, 2021

fix fabric8io#3271: refining the wait logic

7ded399
added this to the 5.5.0 milestone on Jun 28, 2021
shawkins

shawkins commented on Jun 28, 2021

@shawkins
ContributorAuthor

After this change the internal wait code can be mostly cleaned up: 63d555d (not all of the tests were updated yet)

However that code shows there is inconsistent handling of the interrupted exception. At least for our own internal usage it would be better to not throw it directly from waitUntilCondition and instead use a KubernetesClientException. Since the proposed change is already breaking wrt exception handling, could we make that change as well?

The only remaining waiting scenario is a pod list scenario, which could be addressed by #3278

added a commit that references this issue on Jun 29, 2021

fix fabric8io#3271: refining the wait logic

a556866
manusa

manusa commented on Jun 29, 2021

@manusa
Member

...interrupted exception....instead use a KubernetesClientException...
I guess that now that the underlying behavior has changed, it no longer makes sense to have it as part of the method signature.

The change should not be breaking (strictly speaking) since KubernetesClientException is unchecked

added a commit that references this issue on Jun 29, 2021

fix fabric8io#3271: refining the wait logic

2cebbcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @manusa@shawkins

      Issue actions

        waitUntilCondition resource too old exception · Issue #3271 · fabric8io/kubernetes-client