Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find way to capture unintended changes in semantics or api #2650

Closed
iocanel opened this issue Dec 7, 2020 · 4 comments
Closed

Find way to capture unintended changes in semantics or api #2650

iocanel opened this issue Dec 7, 2020 · 4 comments

Comments

@iocanel
Copy link
Member

iocanel commented Dec 7, 2020

The kubernetes-client does try to stay true to semnatic versioning as much as possible (at least for major changes).

Still, there are changes that may untintentionally change things, for example:

  • a change in kubernetes/openshift code itself
  • a change in the generator code
  • an internal change that affects the client behavior.

I am pretty sure that there is tooling out there that could ensure that we capture changes in our public API during CI.

In addition, there might be tools that check the structure of the HTTP requests the client generates under a fixed set of circumstances. Even if they don't we do have our own mocking framework, so we could possibly extract infomration for there.

These are just some ideas we could possibly use to further guard our users.

@manusa
Copy link
Member

manusa commented Dec 7, 2020

Relates to: #2518

@maxandersen
Copy link

Revapi is what we are looking at in quarkus to do this. For Kubernetes which is much smaller it should be fairly easy to enable.

@stale
Copy link

stale bot commented Apr 8, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Apr 8, 2021
@stale
Copy link

stale bot commented Jul 7, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jul 7, 2021
@stale stale bot closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants