fix: ConfigMap and other resources are replaced #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Sep 1, 2020
manusa
force-pushed
the
fix/config-map-replace
branch
from
777c885
to
8dfbbea
Compare
- Reverted **behavior** of BaseOperation#createOrReplace method (and similar) to the previous behavior. API will always be hit, POST to try to create, and PUT in case POST fails. This reverts the behavior trying to mimic kubectl and not performing the second PUT request in case the resource is identical to the server version.
manusa
force-pushed
the
fix/config-map-replace
branch
from
8dfbbea
to
aa651fa
Compare
|
@manusa I have the same issue... could we get an estimate for the next release featuring this patch? |
|
SonarCloud Quality Gate failed.
|
rohanKanojia
approved these changes
Sep 2, 2020
|
[merge] |
|
Patch should be available in https://github.com/fabric8io/kubernetes-client/releases/tag/v4.11.1 |
|
Thanks for the quick response... I have another issue that I hoped to be fixed by that code as well, but alas no! |
Sorry to hear that :( I hope is not too critical.
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2445 : ConfigMap and other resources are replaced
to the previous behavior.
API will always be hit, POST to try to create, and PUT in case POST fails.
This reverts the behavior trying to mimic kubectl and not performing
the second PUT request in case the resource is identical to the server version.
Type of change
test, version modification, documentation, etc.)
Checklist
I have added/updated the javadocs and other documentation accordingly