Replacing ingress with createOrReplace ignores changes to annotations

[BartXZX]

Hi guys,

I am replacing Kubernetes resources with client.resourceList(yaml).inNamespace(namespace).createOrReplace(), but my ingresses do not get replaced when only the annotations have changed. I use this for example to set/unset the nginx.ingress.kubernetes.io/whitelist-source-range annotation.
It looks like ResourceCompare#equals compares only labels, and not annotations.

Is this intentional, and do I need to work around this, or is this a bug?

[rohanKanojia]

Related to #2292

[BartXZX]

@rohanKanojia Do you expect the related ticket to fix this issue?

[rohanKanojia]

Umm, yeah. We're planning to refactor behavior of createOrReplace to do create() first and in case it fails with 409 do a replace
I think right now we're checking whether object has changed or not ourselves which is not aligning with kubectl behavior in my opinion.

[BartXZX]

Great! I've worked around it for now with a delete and apply, but this is less than ideal in case DNS decides to propagate the delete and not the create due to the timing of the ingress creation. Do you have an idea of when #2292 might be picked up?

[rohanKanojia]

It's already in our Sprint backlog: https://github.com/eclipse/jkube/projects/6 . We would try it pick it whenever we can.

[rohanKanojia]

I think this issue should be fixed via #2372 , I've added a test for this case here:

kubernetes-client/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/NetworkingV1beta1IngressTest.java

Lines 206 to 229 in 14cae94

	void testCreateOrReplaceWhenAnnotationUpdated() {
	// Given
	Ingress ingressFromServer = new IngressBuilder().withNewMetadata().withName("ing1").endMetadata().build();
	Ingress ingressUpdated = new IngressBuilder(ingressFromServer).editOrNewMetadata()
	.addToAnnotations("nginx.ingress.kubernetes.io/rewrite-target", "/")
	.endMetadata().build();
	server.expect().post().withPath("/apis/networking.k8s.io/v1beta1/namespaces/ns1/ingresses")
	.andReturn(HttpURLConnection.HTTP_CONFLICT, ingressFromServer).once();
	server.expect().get().withPath("/apis/networking.k8s.io/v1beta1/namespaces/ns1/ingresses/ing1")
	.andReturn(HttpURLConnection.HTTP_OK, ingressFromServer).times(2);
	server.expect().put().withPath("/apis/networking.k8s.io/v1beta1/namespaces/ns1/ingresses/ing1")
	.andReturn(HttpURLConnection.HTTP_OK, ingressUpdated).once();
	KubernetesClient client = server.getClient();
	// When
	ingressUpdated = client.network().ingresses().inNamespace("ns1").createOrReplace(ingressUpdated);
	// Then
	assertNotNull(ingressUpdated);
	assertNotNull(ingressUpdated.getMetadata());
	assertTrue(ingressUpdated.getMetadata().getAnnotations().containsKey("nginx.ingress.kubernetes.io/rewrite-target"));
	}
	}

[rohanKanojia]

Closing this issue. But feel free to reopen if it doesn't work for you or you face any other problems.