Patching a serviceaccount

[mikebell90]

I'm moving over from official kubernetes java client to fabric8. When I wanted to patch a service account before, I generated a json patch and things worked nicely. However this always fails with fabric8, the api server rejects with a 422.

apiClient.serviceAccounts().inNamespace(namespace).withName(name).patch(PatchContext.of(PatchType.JSON),jsonPatchStr);

with jsonPatchStr = (note it's an array of patches)

[{            "op": "add",                "path": "/metadata/labels/app",                "value": "dipun"},{            "op": "add",                "path": "/metadata/labels/foo",                "value": "bar"},{            "op": "add",                "path": "/metadata/labels/otmetaComponent",                "value": "newthing"}]

Gets error

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PATCH at: https://k8s-test-ci-rs.otenv.com:6443/api/v1/namespaces/infra/serviceaccounts/bfb1ae46ec5e47058660ed317633b815. Message: the server rejected our request due to an error in our request. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[], group=null, kind=null, name=null, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=the server rejected our request due to an error in our request, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={})

I have also tried base64ing the json patch.

[rohanKanojia]

@mikebell90 : Hello, I tried reproducing the issue on minikube but for me labels seem to be added in ServiceAccount. Which version of KubernetesClient are you using?

I tried these methods:

    String jsonPatchStr = "[{            \"op\": \"add\",                \"path\": \"/metadata/labels/app\",                \"value\": \"dipun\"},{            \"op\": \"add\",                \"path\": \"/metadata/labels/foo\",                \"value\": \"bar\"},{            \"op\": \"add\",                \"path\": \"/metadata/labels/otmetaComponent\",                \"value\": \"newthing\"}]";
    kubernetesClient.serviceAccounts().inNamespace("default").withName("build-robot")
        .patch(PatchContext.of(PatchType.JSON),jsonPatchStr);

    kubernetesClient.serviceAccounts().inNamespace("default").withName("build-robot")
        .edit(s -> new ServiceAccountBuilder(s)
            .editOrNewMetadata()
            .addToLabels("app", "dipun")
            .addToLabels("foo", "bar")
            .addToLabels("otmetaComponent", "newthing")
            .endMetadata()
            .build());

[mikebell90]

Exception in thread "main" io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PATCH at: https://k8s-test-ci-rs.otenv.com:6443/api/v1/namespaces/infra/serviceaccounts/foo. Message: the server rejected our request due to an error in our request. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[], group=null, kind=null, name=null, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=the server rejected our request due to an error in our request, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={}).
	at io.fabric8.kubernetes.client.KubernetesClientException.copyAsCause(KubernetesClientException.java:238)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.waitForResult(OperationSupport.java:507)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.handleResponse(OperationSupport.java:524)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.handlePatch(OperationSupport.java:419)
	at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.patch(HasMetadataOperation.java:269)
	at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.patch(HasMetadataOperation.java:45)
	at com.opentable.service.account.create.Patching.main(Patching.java:150)
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PATCH at: https://k8s-test-ci-rs.otenv.com:6443/api/v1/namespaces/infra/serviceaccounts/foo. Message: the server rejected our request due to an error in our request. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[], group=null, kind=null, name=null, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=the server rejected our request due to an error in our request, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={}).
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.requestFailure(OperationSupport.java:660)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.requestFailure(OperationSupport.java:640)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.assertResponseCode(OperationSupport.java:589)
	at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.lambda$handleResponse$0(OperationSupport.java:549)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)
	at io.fabric8.kubernetes.client.http.StandardHttpClient.lambda$completeOrCancel$10(StandardHttpClient.java:140)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)
	at io.fabric8.kubernetes.client.http.ByteArrayBodyHandler.onBodyDone(ByteArrayBodyHandler.java:52)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)
	at io.fabric8.kubernetes.client.okhttp.OkHttpClientImpl$OkHttpAsyncBody.doConsume(OkHttpClientImpl.java:137)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)

[mikebell90]

also fails with latest release, same error (6.10.0

[mikebell90]

The "edit" version DOES work, but I really would prefer the JSON patch approach given current code base tests.

[mikebell90]

Even a single patch in array like
jsonPatchStr = "[{ "op": "add", "path": "/metadata/labels/otmetaComponent", "value": "component"}]";

fails

[rohanKanojia]

@mikebell90 : I tried it again but couldn't reproduce it. I'm using 6.11-SNAPSHOT KubernetesClient, minikube v1.32.0 and Kubernetes 1.28.0 .

Is it possible to share some reproducer project?