Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #263: use filter in lieu of filter_stream as recommended optimization #276

Merged
merged 1 commit into from Jun 24, 2022

Conversation

jcantrill
Copy link
Contributor

fix #263: use filter in lieu of filter_stream as recommended optimiza

@jcantrill
Copy link
Contributor Author

cc @ewolinetz @alanconway @vimalk78 are takers for review?

Copy link
Collaborator

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK, but I dont' see the changes to callers of filter_stream

@jcantrill
Copy link
Contributor Author

The change looks OK, but I dont' see the changes to callers of filter_stream

@alanconway I believe the callers are unknown to most users as it handled internally by fluentd when you define use of the plugin via configuration. It is fluentd that makes the optimization.

plugin = create_driver.instance
plugin.filter_stream('tag', nil)
plugin.filter_stream('tag', Fluent::MultiEventStream.new)
d.filtered_records
end

test 'inability to connect to the api server handles exception and doensnt block pipeline' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/doensnt/doesn't

@alanconway
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change filter_stream to filter
3 participants