Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

FabricDiscoveryAgent makes use of system properties for Zookeeper.url and zookeeper.password #7075

Open
tggm opened this issue Jul 10, 2018 · 0 comments

Comments

@tggm
Copy link

tggm commented Jul 10, 2018

The FabricDiscoveryAgent class (FQDN: io.fabric8.mq.fabric.discovery.FabricDiscoveryAgent) expects system properties for the URL and password of the ZK.

This is not a clean implementation, especially in a world of JNDI, Spring and properties files. It forces the user to pass properties to the runtime where their application runs to add these things, especially if the application runs inside some application server/JVM container where these things are not segregatable.

I then request that these properties be configurable from the "top", ie. from the ActiveMQConnectionFactory so that the ZK's URL and Password can be read from a proper configuration source.

Also, the default to "localhost:2181" (on the call() method) doesn't make much sense. Usually libraries connect where they're told and not to defaults buried deep inside the code.

master dependency: io.fabric8.mq:mq-fabric:1.2.0.redhat-621084

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant