Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 support to I/O operations. #126

Merged
merged 20 commits into from Oct 12, 2022
Merged

Add s3 support to I/O operations. #126

merged 20 commits into from Oct 12, 2022

Conversation

fabiocaccamo
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 98.48% // Head: 97.01% // Decreases project coverage by -1.46% ⚠️

Coverage data is based on head (44f302d) compared to base (a1e5b9f).
Patch coverage: 56.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   98.48%   97.01%   -1.47%     
==========================================
  Files          57       57              
  Lines        1646     1676      +30     
==========================================
+ Hits         1621     1626       +5     
- Misses         25       50      +25     
Flag Coverage Δ
unittests 97.01% <56.45%> (-1.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
benedict/dicts/io/io_dict.py 98.97% <ø> (-0.04%) ⬇️
benedict/serializers/__init__.py 100.00% <ø> (ø)
benedict/dicts/io/io_util.py 72.16% <56.45%> (-24.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabiocaccamo fabiocaccamo merged commit 5ac299d into master Oct 12, 2022
@fabiocaccamo fabiocaccamo restored the s3 branch February 1, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant