Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shallow merge in tsconfigOverride where TS does so -- match tsconfig extends #86

Open
ezolenko opened this issue Jun 6, 2018 · 1 comment
Open

Shallow merge in tsconfigOverride where TS does so -- match tsconfig extends #86

ezolenko opened this issue Jun 6, 2018 · 1 comment
Assignees
@agilgur5
Labels
kind: bug Something isn't working properly PR welcome priority: high solution: workaround available There is a workaround available for this issue

Comments

@ezolenko
Copy link
Owner

ezolenko commented Jun 6, 2018 •
edited

What happens and why it is wrong

typescript is using shallow merge on some elements (paths, possibly includes etc). Need to make plugin behave the same way to reduce surprises.

#72
@ezolenko ezolenko added kind: feature New feature or request and removed kind: feature New feature or request labels Jan 18, 2019
@agilgur5 agilgur5 mentioned this issue Oct 9, 2020
Closed
@agilgur5 agilgur5 added the kind: bug Something isn't working properly label May 3, 2022
@agilgur5
Copy link
Collaborator

agilgur5 commented May 3, 2022

Per the TS docs on extends -- which we should treat as a "source of truth" -- the fields that should be shallow merged (replaced, rather) are files, include, and exclude.

Basically all the top-level arrays.
paths isn't mentioned. It's possible that's just missing docs though, but I haven't checked the TS API to confirm which it does.
Also references specifically isn't inherited, so not sure if we want to have the same behavior for that one or not.

This was referenced May 3, 2022
Merged
Closed
@agilgur5 agilgur5 added the solution: workaround available There is a workaround available for this issue label May 8, 2022
@agilgur5 agilgur5 mentioned this issue May 14, 2022
Merged
@agilgur5 agilgur5 mentioned this issue May 21, 2022
Closed
@agilgur5 agilgur5 self-assigned this Jun 2, 2022
@agilgur5 agilgur5 mentioned this issue Jun 14, 2022
Closed
@agilgur5 agilgur5 mentioned this issue Jul 22, 2022
Merged
This was referenced Sep 5, 2022
Closed
Merged
@agilgur5 agilgur5 changed the title Switch to shallow merge in tsconfigOverride where typescript does shallow merge Switch to shallow merge in tsconfigOverride where TS does so -- match tsconfig extends behavior Sep 11, 2022
@agilgur5 agilgur5 changed the title Switch to shallow merge in tsconfigOverride where TS does so -- match tsconfig extends behavior Shallow merge in tsconfigOverride where TS does so -- match tsconfig extends Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agilgur5 agilgur5

Labels
kind: bug Something isn't working properly PR welcome priority: high solution: workaround available There is a workaround available for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezolenko @agilgur5