Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Force
noEmitOnError: false
for the same reason we forcenoEmit: false
failed to transpile
error --noEmitOnError: true
breaks rpt2 #254Details
noEmitOnError: true
acts likenoEmit: true
when there is an erroremitSkipped
set totrue
, which this plugin interprets as a fatal errortransform
hookthis has only been reported as an issue once so far, probably because it defaults to
false
in TS and, as such, is rarely usedfalse
(i.e. the default) because they don't realize theabortOnError
option exists (c.f.noEmitOnError: false
seems to be ignored -- use plugin optionabortOnError
#62 and its duplicates)add
noEmitOnError: false
to the forced options list and tests tooadd it to the docs on what tsconfig options are forced
abortOnError
since they're commonly associated with each other and that plugin option is often missed (per above)briefly explain that
noEmit
andnoEmitOnError
arefalse
because Rollup controls emit settings in the context of this plugin, instead oftsc
etcCan see more details in my root cause analysis in #254 (comment)
Related feature request: #168