refactor: invert some conditionals for better readability #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small refactor to invert some conditionals/
if
statements for better readabilityDetails
a few
if (cond) { big block } return
could be inverted toif (!cond) return
then the block un-indented insteadshorten the
resolvedFileName
conditional by using optional chainingx?.y
over the olderx && x.y
syntaxadd a
resolved
variable for less repetition of the whole statementadd a comment to the
pathNormalize
line about why it's used in that one place and link to the longer description in the PR as wellshorten comment about
useTsconfigDeclarationDir
so it doesn't take up so much space or look so important as a resultremove the
else
there and just add an early return instead, similar to the inverted conditionals aboveReview Notes
This is unfortunately going to merge conflict with fix: don't attempt to change declarationMap
sources
when no output #334 as one of the conditionals is changed there as well, so I'll need to rebase this once that's fixedIgnoring whitespace changes makes this PR easier to read