Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap types so we don't have to re-export owo_colors #150

Open
jssblck opened this issue Mar 11, 2024 · 2 comments
Open

Wrap types so we don't have to re-export owo_colors #150

jssblck opened this issue Mar 11, 2024 · 2 comments

Comments

@jssblck
Copy link

jssblck commented Mar 11, 2024

Hey there! I read #109, and understand why owo_colors is re-exported, but the original author is quite correct that it makes completions really noisy. They were using IntelliJ, but I'm using VS Code with Rust Analyzer and it has this same issue.

Would you accept a PR that newtype-wraps all the owo_colors bits so that it doesn't have to be re-exported?

I'm envisioning, for example:

  • color_eyre::config::Theme::file accepts owo_colors::Style today.
  • We could make it instead accept a new trait, e.g. impl color_eyre::config::Style, which is automatically implemented by owo_colors::Style.

And so on.

@belakm
Copy link

belakm commented Mar 25, 2024

I second this 👍 developer experience with unrelated auto-suggestions is unpleasant

the alternative i took at the moment is going back to eyre crate

@FlareFlo
Copy link

Alternatively, the re-export could be feature gated, optionally disabling it when unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants