You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would consider this not a bug. Since 48037df (#114), install() does not panic, but returns a Result.
Previously, install itself panicked. This is fixed. However, if you unwrap the Result::Err, you cause a panic in your own code.
If you want to freely call install() multiple times, then use .ok() rather than .unwrap() to silence the resulting (#[must_use]) Result::Err by turning it into Option::None.
/// Does not panic.fndouble_install_should_not_panic(){install().ok();install().ok();install().ok();assert!(install().is_err());}
I have reviewed #78 and #144
But the problem is still not fixed
https://github.com/yaahc/color-eyre/blob/4a7b4d6988c6b0da5e04e29c9d6e10595b5dc302/tests/install.rs#L4-L7
I modified with
it's still panic
The text was updated successfully, but these errors were encountered: