feat(handler): add methods to mutate and remove backtrace/spantrace #131

gibfahn · 2023-04-18T21:27:41Z

Commits (oldest to newest)

d3da7e1 feat(handler): add methods to mutate and remove backtrace/spantrace

Fixes: #130

gibfahn · 2023-04-18T21:33:14Z

src/handler.rs

+    /// Return a mutable reference to the captured `Backtrace` type
+    pub fn backtrace_mut(&mut self) -> Option<&mut Backtrace> {
+        self.backtrace.as_mut()
+    }
+
+    /// Remove the captured `Backtrace` if present.
+    pub fn clear_backtrace(&mut self) {
+        self.backtrace = None;
+    }


I initially tried to use the .backtrace_mut() as in #130 (comment) , and it didn't work as it returns Option<&mut Backtrace> rather than &mut Option<Backtrace>.

I think that's more idiomatic rust, and so having two methods makes sense, but if you'd rather we delete clear_backtrace() and change the signature of backtrace_mut to:

pub fn backtrace_mut(&mut self) -> &mut Option<Backtrace> {

that works for me too.

feat(handler): add methods to mutate and remove backtrace/spantrace

d3da7e1

Fixes: eyre-rs#130

gibfahn force-pushed the clear_backtrace branch from b681cce to d3da7e1 Compare April 18, 2023 21:30

gibfahn commented Apr 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(handler): add methods to mutate and remove backtrace/spantrace #131

feat(handler): add methods to mutate and remove backtrace/spantrace #131

gibfahn commented Apr 18, 2023 •

edited

gibfahn Apr 18, 2023

feat(handler): add methods to mutate and remove backtrace/spantrace #131

Are you sure you want to change the base?

feat(handler): add methods to mutate and remove backtrace/spantrace #131

Conversation

gibfahn commented Apr 18, 2023 • edited

Commits (oldest to newest)

gibfahn Apr 18, 2023

Choose a reason for hiding this comment

gibfahn commented Apr 18, 2023 •

edited