Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observe SDK support to the Extism runtime #470

Open
bhelx opened this issue Sep 19, 2023 · 3 comments
Open

Add Observe SDK support to the Extism runtime #470

bhelx opened this issue Sep 19, 2023 · 3 comments
Assignees

Comments

@bhelx
Copy link
Contributor

bhelx commented Sep 19, 2023

It would be great if we had Observe support in the Extism runtime. For ourselves and for our users. I think the primary blocker on this one is tokio / async support in Extism as that's required by the SDK. Perhaps there is another way.

@zshipko do you mind filling in some details on what we need to accomplish this goal?

@bhelx bhelx changed the title Add Observe SDK support to Extism Add Observe SDK support to the Extsim runtime Sep 19, 2023
@zshipko
Copy link
Contributor

zshipko commented Sep 19, 2023

I have tried converting the runtime to use the wasmtime async API, but this complicates the C API because we need to block on the future to return it from the SDK functions. It brings up the question of what runtime to support, do we go with tokio or try to support async-std too? I think doing this would still be possible but it's a lot of work.

The thing I haven't tried is to re-implement the observe SDK as Extism host functions in https://github.com/extism/extism/blob/main/runtime/src/pdk.rs - which seems like the most realistic path to observe support with what is available in Extism today.

@bhelx bhelx changed the title Add Observe SDK support to the Extsim runtime Add Observe SDK support to the Extism runtime Oct 2, 2023
@neuronicnobody
Copy link
Contributor

Only Otel support

@neuronicnobody
Copy link
Contributor

@bhelx follow up with Zach on priority for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants