Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug to the latest version #115

Closed
kireerik opened this issue May 24, 2017 · 8 comments
Closed

Update debug to the latest version #115

kireerik opened this issue May 24, 2017 · 8 comments
Assignees
Labels

Comments

@kireerik
Copy link

This would fix the following vulnerability: https://snyk.io/test/github/expressjs/compression/1.6.2

@kyrylkov
Copy link

Is there a reason to have debug dependency without tilde

@sshen81
Copy link

sshen81 commented May 25, 2017

@dougwilson Have experienced the same issue. debug package release >= 2.6.8 has upgraded the ms dependency to address the snyk vulnerability.

@dougwilson
Copy link
Contributor

Hi everyone, is this a false positive for the vulnerability or is there a way you can exploit the compression module though this? The current version published has debug: ~2.2.0, which has the tilde @kyrylkov but it's still a few minor behind, so the tilde doesn't work. I'll publish a new version within like 12 hours or so unless there is an actual exploit here and it's just not a false positive.

@kyrylkov
Copy link

kyrylkov commented May 25, 2017

@dougwilson ms acknowledged the issue vercel/ms#89 As you see it's been already 9 days so it can wait another 12 hours.

@dougwilson
Copy link
Contributor

Hi @kyrylkov is this a false positive for the vulnerability or is there a way you can exploit the compression module though this?

@kyrylkov
Copy link

@dougwilson I don't think compression can be exploited, since compression doesn't depend on ms, while debug uses ms only for microsecond logging. However I am not a security exprert.

@dougwilson
Copy link
Contributor

From my understanding, it only applies when you are using ms(string_var), but the debug module is only calling ms(number_var), so I don't think the vulnerability applies here.

@dougwilson
Copy link
Contributor

Didn't mean to fat finger comment + close; just no longer need more info; there is no rush to update since there is no vulnerability here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants