Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo AV setRateAsync() corrects pitch everytime on Windows browser in development build irrespective of "shouldCorrectPitch" parameter #28828

Closed
THE-BLUE-FRIEND opened this issue May 14, 2024 · 1 comment · Fixed by #28837
Closed

Expo AV setRateAsync() corrects pitch everytime on Windows browser in development build irrespective of "shouldCorrectPitch" parameter #28828

THE-BLUE-FRIEND opened this issue May 14, 2024 · 1 comment · Fixed by #28837
Assignees
@behenate
Labels
Issue accepted

Comments

@THE-BLUE-FRIEND
Copy link

Minimal reproducible example

https://github.com/THE-BLUE-FRIEND/ExpoIssues

What platform(s) does this occur on?

Web

Did you reproduce this issue in a development build?

Yes

Summary

The setRateAsync() function works correctly on Android as presented in the documentation. However, when I produce a development build for Windows Web browsers, it is not working as expected. I have not yet tested it in production mode though.

Environment

Need to install the following packages:
expo-env-info@1.2.0
Ok to proceed? (y) y


  expo-env-info 1.2.0 environment info:
    System:
      OS: Windows 11 10.0.22631
    Binaries:
      Node: 21.7.1 - D:\nodejs\node.EXE
      npm: 10.7.0 - D:\nodejs\npm.CMD
    npmPackages:
      expo: ~51.0.5 => 51.0.5 
      react: 18.2.0 => 18.2.0 
      react-dom: 18.2.0 => 18.2.0 
      react-native: 0.74.1 => 0.74.1 
      react-native-web: ~0.19.10 => 0.19.11 
    Expo Workflow: managed

Expo Doctor Diagnostics

Need to install the following packages:
expo-doctor@1.6.0
Ok to proceed? (y) y

(node:8432) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
WARNING: We recommend using PowerShell or Bash via WSL 2 for development with Expo CLI on Windows. You may encounter issues using cmd.exe.

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check npm/ yarn versions
✔ Check for issues with metro config
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check for legacy global CLI installed locally
✔ Check that native modules do not use incompatible support packages
✔ Check that native modules use compatible support package versions for installed Expo SDK
✔ Check that packages match versions required by installed Expo SDK

Didn't find any issues with the project!
@THE-BLUE-FRIEND THE-BLUE-FRIEND added the needs validation Issue needs to be validated label May 14, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels May 14, 2024
@behenate behenate added Issue accepted and removed needs review Issue is ready to be reviewed by a maintainer labels May 14, 2024
@behenate behenate self-assigned this May 14, 2024
@expo-bot
Copy link
Collaborator

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

@behenate behenate mentioned this issue May 14, 2024
Merged
behenate added a commit that referenced this issue May 15, 2024
@behenate
[av][web] Fix should shouldCorrectPitch not working on web (#28837)
1a9913d 
# Why

`shouldCorrectPitch` was ignored on web. 
Fixes #28828

# How

Used `preservesPitch` property to obtain the desired behaviour

# Test Plan

Tested in NCL on web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behenate behenate

Labels
Issue accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[av][web] Fix should shouldCorrectPitch not working on web expo/expo
4 participants
@behenate @expo-bot @THE-BLUE-FRIEND and others